go/e2e/workload-queries: allow historical QueryTxs to fail few times
#3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/feature/workload-queries-fail
branch
from
98efc41
to
3ed2895
Compare
Codecov Report
@@ Coverage Diff @@
## master #3338 +/- ##
==========================================
- Coverage 65.59% 65.27% -0.32%
==========================================
Files 371 371
Lines 33151 33151
==========================================
- Hits 21745 21640 -105
- Misses 8227 8312 +85
- Partials 3179 3199 +20
Continue to review full report at Codecov.
|
kostko
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
QueryTxsin the daily E2E tests will fail in case it's done for a height for which active storage nodes are missing historical state due to restoring from snapshots (#3337). Note: for this to happen also thestorage-0needs to not be in the committee for the epoch (sincestorage-0is never restarted it has all the state), and the other storage node (which likely has the state) is down (e.g. due to just being restarted), therefore this should happen rarely.This makes the E2E test not fail in those cases.