Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/nancy: remove fixed 'golang.org/x/net' false positive ignores #3340

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 30, 2020

Should be fixed now: sonatype-nexus-community/nancy#189

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #3340 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3340      +/-   ##
==========================================
- Coverage   65.34%   65.26%   -0.09%     
==========================================
  Files         371      371              
  Lines       33151    33151              
==========================================
- Hits        21662    21635      -27     
- Misses       8284     8311      +27     
  Partials     3205     3205              
Impacted Files Coverage Δ
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/staking/api/grpc.go 52.10% <0.00%> (-6.73%) ⬇️
go/consensus/tendermint/abci/mux.go 48.78% <0.00%> (-5.26%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
go/storage/metrics.go 80.00% <0.00%> (-4.62%) ⬇️
go/worker/storage/service_external.go 48.14% <0.00%> (-3.71%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 72.41% <0.00%> (-3.45%) ⬇️
go/worker/common/committee/node.go 74.86% <0.00%> (-2.80%) ⬇️
go/consensus/tendermint/staking/staking.go 52.83% <0.00%> (-2.52%) ⬇️
go/storage/database/database.go 68.23% <0.00%> (-2.36%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc43f8...e3ad646. Read the comment docs.

@ptrus ptrus merged commit 13125b8 into master Sep 30, 2020
@ptrus ptrus deleted the ptrus/fix/fixed-nancy-false branch September 30, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants