Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/dependencies/etcd: update etcd with replace directive #3341

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 30, 2020

With updated nancy (done in #3283) we now use go list -json -m all to get the list of dependencies, which does correctly take replace directive into account. Therefore we can now replace the vulnerable etcd and remove the CVE ignores.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #3341 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3341      +/-   ##
==========================================
- Coverage   65.44%   65.29%   -0.16%     
==========================================
  Files         371      371              
  Lines       33151    33151              
==========================================
- Hits        21697    21645      -52     
- Misses       8251     8315      +64     
+ Partials     3203     3191      -12     
Impacted Files Coverage Δ
go/storage/mkvs/checkpoint/checkpointer.go 64.75% <0.00%> (-15.58%) ⬇️
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/staking/api/grpc.go 51.26% <0.00%> (-7.57%) ⬇️
go/keymanager/client/client.go 81.41% <0.00%> (-6.20%) ⬇️
go/consensus/tendermint/apps/registry/query.go 76.47% <0.00%> (-5.89%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 75.00% <0.00%> (-5.00%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
go/storage/mkvs/lookup.go 72.63% <0.00%> (-4.22%) ⬇️
go/consensus/tendermint/registry/registry.go 70.24% <0.00%> (-3.91%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.13% <0.00%> (-3.78%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13125b8...c389110. Read the comment docs.

@ptrus ptrus merged commit 007ccf6 into master Sep 30, 2020
@ptrus ptrus deleted the ptrus/fix/replace-etcd branch September 30, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants