go/e2e/queries: correctly ignore UnexpectedEOF errors #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/fix/workload-queries-eof
branch
from
9b475f7
to
d48be06
Compare
Codecov Report
@@ Coverage Diff @@
## master #3372 +/- ##
==========================================
+ Coverage 65.68% 65.72% +0.03%
==========================================
Files 371 371
Lines 33187 33187
==========================================
+ Hits 21799 21811 +12
+ Misses 8151 8141 -10
+ Partials 3237 3235 -2
Continue to review full report at Codecov.
|
kostko
approved these changes
Oct 5, 2020
| if status.Err() == io.ErrUnexpectedEOF { | ||
| if st := cmnGrpc.GetErrorStatus(err); st != nil { | ||
| s, _ := status.FromError(io.ErrUnexpectedEOF) | ||
| if st.Err().Error() == s.Err().Error() { |
There was a problem hiding this comment.
Yeah, unfortunately i didn't find a nicer way of doing this (the alternative would be directly matching on string - well which is kinda close to what this is doing, but at least here there's no hardcoded strings here :P)
ptrus
force-pushed
the
ptrus/fix/workload-queries-eof
branch
from
d48be06
to
fdc6c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working fix from: #3302 , now with tests