Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/backoff: Update cenkalti/backoff to 4.1.0 #3390

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Oct 8, 2020

Out upstream patch was accepted and released so the EnsurePermanent workaround can be simplified to only special case the context.Canceled method.

@ptrus ptrus force-pushed the ptrus/feature/update-backoff branch from 5b24d64 to e1525a6 Compare October 8, 2020 12:11
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #3390 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3390      +/-   ##
==========================================
- Coverage   66.15%   66.08%   -0.08%     
==========================================
  Files         371      371              
  Lines       33293    33285       -8     
==========================================
- Hits        22024    21995      -29     
- Misses       8039     8055      +16     
- Partials     3230     3235       +5     
Impacted Files Coverage Δ
go/worker/common/p2p/error/error.go 100.00% <100.00%> (ø)
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/storage/mkvs/checkpoint/checkpointer.go 64.75% <0.00%> (-15.58%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/staking/api/grpc.go 51.26% <0.00%> (-7.57%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.27% <0.00%> (-4.66%) ⬇️
go/storage/api/metrics.go 86.15% <0.00%> (-4.62%) ⬇️
go/consensus/tendermint/abci/mux.go 57.67% <0.00%> (-3.94%) ⬇️
go/storage/api/root_cache.go 78.33% <0.00%> (-3.34%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d1229...e1525a6. Read the comment docs.

@ptrus ptrus merged commit 9ac86b8 into master Oct 8, 2020
@ptrus ptrus deleted the ptrus/feature/update-backoff branch October 8, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants