Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime upgrade E2E test should wait for old node expiration #3404

Closed
kostko opened this issue Oct 14, 2020 · 1 comment · Fixed by #3435
Closed

Runtime upgrade E2E test should wait for old node expiration #3404

kostko opened this issue Oct 14, 2020 · 1 comment · Fixed by #3435
Assignees
Labels
c:bug Category: bug c:testing Category: testing

Comments

@kostko
Copy link
Member

kostko commented Oct 14, 2020

Currently the runtime upgrade E2E test shuts down the old compute nodes after upgrade and starts the client, assuming that the new compute nodes will process the transactions:

// Kill old compute workers.
sc.Logger.Info("stopping old runtimes")
for i := 0; i < sc.firstNewWorker; i++ {
worker := sc.Net.ComputeWorkers()[i]
if err = worker.Stop(); err != nil {
return fmt.Errorf("stopping old compute worker: %w", err)
}
}
// Start the new compute workers.

The problem is that the committee scheduler can still schedule one of the old nodes, making the test flaky as it depends on what committee is elected. We should probably wait for the old nodes to expire before proceeding.

@kostko kostko added c:testing Category: testing c:bug Category: bug labels Oct 14, 2020
@Yawning
Copy link
Contributor

Yawning commented Oct 19, 2020

This blocks #3180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:testing Category: testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants