Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common/committee: check if active epoch exists #3432

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Oct 19, 2020

Fixes nil ptr defer that can happen if the executor node tries to publish a message before it's synced

@ptrus ptrus force-pushed the ptrus/fix/handle-peer-nilptr branch from 1df156c to b13bad6 Compare October 19, 2020 12:52
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #3432 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3432   +/-   ##
=======================================
  Coverage   65.98%   65.99%           
=======================================
  Files         371      371           
  Lines       33366    33368    +2     
=======================================
+ Hits        22016    22020    +4     
+ Misses       8110     8095   -15     
- Partials     3240     3253   +13     
Impacted Files Coverage Δ
go/worker/common/committee/group.go 76.36% <0.00%> (-0.71%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/worker/compute/executor/committee/state.go 71.42% <0.00%> (-14.29%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/common/grpc/proxy/proxy.go 65.74% <0.00%> (-5.56%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 70.00% <0.00%> (-5.00%) ⬇️
go/worker/common/committee/runtime_host.go 65.04% <0.00%> (-4.86%) ⬇️
go/worker/storage/service_external.go 48.14% <0.00%> (-3.71%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 75.64% <0.00%> (-2.59%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a22bbb...b13bad6. Read the comment docs.

@ptrus ptrus merged commit c8806fa into master Oct 19, 2020
@ptrus ptrus deleted the ptrus/fix/handle-peer-nilptr branch October 19, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants