go/roothash: Refactor runtime messages #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
575b343
to
defd97a
Compare
kostko
added
c:breaking/consensus
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
10 times, most recently
from
03a811d
to
7848257
Compare
kostko
requested review from
peterjgilbert,
pro-wh and
Yawning
as code owners
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
2 times, most recently
from
c8ca0dd
to
a2ef300
Compare
ptrus
reviewed
Nov 3, 2020
abukosek
approved these changes
Nov 6, 2020
Comment on lines
+34
to
+37
| // Make sure somebody actually handled the message, otherwise treat as unsupported. | ||
| if err == tmapi.ErrNoSubscribers { | ||
| err = roothash.ErrInvalidArgument | ||
| } |
There was a problem hiding this comment.
Maybe we should have a different/new error for this case to help distinguish it from the actual unsupported message error above?
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
2 times, most recently
from
754ad83
to
7a4b16d
Compare
kostko
changed the base branch from
master
to
kostko/fix/runtime-mkvs-overlay
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
7a4b16d
to
746c5ff
Compare
kostko
force-pushed
the
kostko/fix/runtime-mkvs-overlay
branch
from
05d664b
to
2661a29
Compare
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
746c5ff
to
4209836
Compare
Codecov Report
@@ Coverage Diff @@
## master #3448 +/- ##
==========================================
+ Coverage 66.44% 66.46% +0.02%
==========================================
Files 373 377 +4
Lines 34029 34270 +241
==========================================
+ Hits 22611 22778 +167
- Misses 8138 8187 +49
- Partials 3280 3305 +25
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
2 times, most recently
from
75ff7e4
to
6442aa3
Compare
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
6442aa3
to
64136db
Compare
ptrus
reviewed
Dec 1, 2020
|
|
||
| // LastNormalRound is the runtime round which was normally processed by the runtime. This is | ||
| // also the round that contains the message results for the last processed runtime messages. | ||
| LastNormalRound uint64 `json:"last_normal_round"` |
There was a problem hiding this comment.
Maybe LastNonEmpty{Round,Height} would be more descriptive? Don't have any better suggestion, but i feel "Normal" is not the most descriptive.
There was a problem hiding this comment.
The reason why I used "Normal" is that this is the header type (HeaderType) of "normal" (:grin:) blocks. I agree that it is not the best term.
There was a problem hiding this comment.
Ah yeah that makes sense :-) Potentially could use LastNormalBlock{Round,Height}, but i'm also fine if it stays at it is.
Use recently introduced message passing between apps instead.
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
64136db
to
443b4f5
Compare
ptrus
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3430
TODO
MaxMessagesagainst globalMaxRuntimeMessagesroothash consensus parameter.