Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ptrus/feature/txsource crash points #3449

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Oct 26, 2020

Fixes: #3409

TODO:

@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch from 66eaee5 to 15b090a Compare October 27, 2020 14:40
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #3449 (9756566) into master (a15d7dd) will increase coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3449      +/-   ##
==========================================
+ Coverage   66.38%   66.45%   +0.06%     
==========================================
  Files         373      373              
  Lines       33943    33954      +11     
==========================================
+ Hits        22534    22564      +30     
+ Misses       8131     8124       -7     
+ Partials     3278     3266      -12     
Impacted Files Coverage 螖
go/common/crash/crash.go 82.05% <75.00%> (-3.03%) 猬囷笍
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) 猬囷笍
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) 猬囷笍
go/staking/api/grpc.go 51.18% <0.00%> (-6.30%) 猬囷笍
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) 猬囷笍
go/storage/mkvs/lookup.go 72.63% <0.00%> (-4.22%) 猬囷笍
.../consensus/tendermint/apps/roothash/state/state.go 74.28% <0.00%> (-2.86%) 猬囷笍
go/consensus/tendermint/staking/staking.go 54.02% <0.00%> (-2.30%) 猬囷笍
go/consensus/tendermint/roothash/roothash.go 70.76% <0.00%> (-1.24%) 猬囷笍
go/consensus/tendermint/abci/mux.go 59.46% <0.00%> (-1.14%) 猬囷笍
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a15d7dd...9756566. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch 4 times, most recently from d97d48e to 0f33654 Compare November 3, 2020 14:56
@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch 12 times, most recently from 4215880 to 59aa1af Compare November 9, 2020 15:41
@ptrus ptrus marked this pull request as ready for review November 9, 2020 17:06
@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch from 59aa1af to 7f55d9a Compare November 9, 2020 17:07
go/common/crash/crash.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/compute.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/compute.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch from 7f55d9a to a80b664 Compare November 10, 2020 13:10
@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch 3 times, most recently from 069f1e8 to f251ce6 Compare November 11, 2020 09:23
@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch from f251ce6 to 6c6317b Compare November 11, 2020 09:25
@ptrus ptrus force-pushed the ptrus/feature/txsource-crash-points branch from 6c6317b to 9756566 Compare November 11, 2020 12:40
@ptrus ptrus merged commit ccc29f5 into master Nov 11, 2020
@ptrus ptrus deleted the ptrus/feature/txsource-crash-points branch November 11, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable crash points in long-term tests
3 participants