Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage node should update access control policy on new storage node registrations #3453

Closed
kostko opened this issue Oct 28, 2020 · 0 comments · Fixed by #3455
Closed

Storage node should update access control policy on new storage node registrations #3453

kostko opened this issue Oct 28, 2020 · 0 comments · Fixed by #3455
Assignees
Labels
c:bug Category: bug c:runtime Category: runtime c:storage Category: storage

Comments

@kostko
Copy link
Member

kostko commented Oct 28, 2020

Currently the storage node only updates its access control policy when either i) the committee changes or ii) a node within the currently elected committee changes (updates its registration). The access control policy for storage nodes includes allowing access to any storage node which is registered for the runtime, but the policy is not updated if none of the above happens (e.g., in case existing nodes don't update registrations and the committee doesn't change).

We should make it so that the storage node watches for storage node registration updates for the given runtime and updates the policy by calling n.updateExternalServicePolicyLocked.

This should be backwards compatible and backported to the 20.11.x stable branch.

@kostko kostko added c:storage Category: storage c:runtime Category: runtime c:bug Category: bug labels Oct 28, 2020
@ptrus ptrus self-assigned this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:runtime Category: runtime c:storage Category: storage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants