Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/crypto: Bump ed25519 version #3458

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Oct 30, 2020

TODO

  • Use proper tag of our Tendermint fork once the fork has been tagged.

@kostko kostko added c:common Category: common libraries c:breaking/consensus Category: breaking consensus changes labels Oct 30, 2020
@kostko kostko force-pushed the kostko/fix/bump-ed25519-verify branch 2 times, most recently from f9a3fc3 to 8400f33 Compare October 30, 2020 16:44
@kostko kostko marked this pull request as ready for review October 30, 2020 16:44
@kostko kostko marked this pull request as draft November 2, 2020 09:05
@kostko kostko force-pushed the kostko/fix/bump-ed25519-verify branch 2 times, most recently from 659b694 to c29eb5f Compare November 2, 2020 09:27
@kostko kostko force-pushed the kostko/fix/bump-ed25519-verify branch from c29eb5f to e8cbc0e Compare November 2, 2020 09:52
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #3458 into master will decrease coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3458      +/-   ##
==========================================
- Coverage   66.43%   66.13%   -0.30%     
==========================================
  Files         371      371              
  Lines       33758    33750       -8     
==========================================
- Hits        22428    22322     -106     
- Misses       8071     8161      +90     
- Partials     3259     3267       +8     
Impacted Files Coverage Δ
go/common/crypto/signature/signature.go 43.29% <ø> (-3.80%) ⬇️
go/registry/tests/tester.go 91.12% <100.00%> (+<0.01%) ⬆️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/staking/api/grpc.go 50.39% <0.00%> (-7.88%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 85.18% <0.00%> (-7.41%) ⬇️
go/consensus/tendermint/abci/mux.go 57.86% <0.00%> (-5.06%) ⬇️
go/worker/common/committee/runtime_host.go 66.99% <0.00%> (-4.86%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 50.00% <0.00%> (-4.32%) ⬇️
go/storage/mkvs/lookup.go 72.63% <0.00%> (-4.22%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c640ae1...b0be62d. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/bump-ed25519-verify branch from e8cbc0e to b0be62d Compare November 2, 2020 10:10
@kostko kostko marked this pull request as ready for review November 2, 2020 10:11
@kostko kostko merged commit 1cff54b into master Nov 2, 2020
@kostko kostko deleted the kostko/fix/bump-ed25519-verify branch November 2, 2020 12:40
tjanez added a commit that referenced this pull request Nov 3, 2020
Since #3360 has been
merged, we stated that from now onwards, only a change in a protocol's
major version signifies a backward-incompatible change.

The change in #3458 is
a breaking change, hence we should bump the consensus protocol's major
version.
tjanez added a commit that referenced this pull request Nov 3, 2020
Since #3360 has been
merged, we stated that from now onwards, only a change in a protocol's
major version signifies a backward-incompatible change.

The change in #3458 is
a breaking change, hence we should bump the consensus protocol's major
version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:common Category: common libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants