Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State of suspended runtimes is not correctly restored after a dump/restore #3484

Closed
kostko opened this issue Nov 5, 2020 · 0 comments · Fixed by #3708
Closed

State of suspended runtimes is not correctly restored after a dump/restore #3484

kostko opened this issue Nov 5, 2020 · 0 comments · Fixed by #3708
Assignees
@ptrus
Labels
c:bug Category: bug c:consensus/tendermint Category: Tendermint-based consensus c:roothash Category: root hash service

Comments

@kostko
Copy link
Member

kostko commented Nov 5, 2020

Roothash state of suspended runtimes is not correctly restored after a dump/restore since the only place where we restore state is at genesis and not later when the runtime becomes unsuspended. This means that for any suspended runtimes the state will be reset.

This should be fixed together with a test for moving a suspended runtime across a dump/restore upgrade.
@kostko kostko added c:roothash Category: root hash service c:consensus/tendermint Category: Tendermint-based consensus c:bug Category: bug labels Nov 5, 2020
@kostko kostko changed the title State of suspended runtimes is not correct restored after a dump/restore State of suspended runtimes is not correctly restored after a dump/restore Nov 6, 2020
@kostko kostko mentioned this issue Jan 12, 2021
Closed
@ptrus ptrus self-assigned this Feb 17, 2021
@ptrus ptrus mentioned this issue Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrus ptrus

Labels
c:bug Category: bug c:consensus/tendermint Category: Tendermint-based consensus c:roothash Category: root hash service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/roothash/genesis: restore state from suspended runtimes oasisprotocol/oasis-core
2 participants
@kostko @ptrus