Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make: Improve project version handling #3492

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Nov 6, 2020

Handle cases where a new version was released and published off the master branch.

@tjanez tjanez added the c:ops Category: operations label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #3492 (aaa9d58) into master (37dafdf) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3492      +/-   ##
==========================================
- Coverage   66.55%   66.33%   -0.22%     
==========================================
  Files         373      373              
  Lines       33924    33924              
==========================================
- Hits        22578    22504      -74     
- Misses       8077     8151      +74     
  Partials     3269     3269              
Impacted Files Coverage Δ
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 85.18% <0.00%> (-7.41%) ⬇️
go/consensus/tendermint/abci/mux.go 57.38% <0.00%> (-5.12%) ⬇️
go/worker/common/committee/runtime_host.go 65.04% <0.00%> (-4.86%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/full/services.go 77.11% <0.00%> (-4.24%) ⬇️
go/staking/api/grpc.go 52.75% <0.00%> (-3.94%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 72.41% <0.00%> (-3.45%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 74.28% <0.00%> (-2.86%) ⬇️
go/storage/mkvs/insert.go 90.41% <0.00%> (-2.74%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37dafdf...aaa9d58. Read the comment docs.

Handle cases where a new version was released and published off the
master branch.
@tjanez tjanez merged commit b2bf595 into master Nov 9, 2020
@tjanez tjanez deleted the tjanez/make-improvements branch November 9, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:ops Category: operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants