Add runtime accounts and staking runtime messages #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
4209836
to
75ff7e4
Compare
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
0c390c8
to
9f8716f
Compare
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
75ff7e4
to
6442aa3
Compare
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
9f8716f
to
49d77bc
Compare
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
6442aa3
to
64136db
Compare
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
49d77bc
to
40f3501
Compare
8 tasks
kostko
force-pushed
the
kostko/feature/runtime-msgs-refactor
branch
from
64136db
to
443b4f5
Compare
Base automatically changed from
kostko/feature/runtime-msgs-refactor
to
master
December 2, 2020 11:21
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
40f3501
to
d4a6617
Compare
Codecov Report
@@ Coverage Diff @@
## master #3511 +/- ##
==========================================
- Coverage 66.48% 66.47% -0.01%
==========================================
Files 377 377
Lines 34288 34469 +181
==========================================
+ Hits 22797 22914 +117
- Misses 8189 8246 +57
- Partials 3302 3309 +7
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
7 times, most recently
from
be5ea4c
to
1d49b8d
Compare
kostko
requested review from
peterjgilbert,
pro-wh and
Yawning
as code owners
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
1d49b8d
to
eca2dcc
Compare
kostko
added
c:breaking/consensus
ptrus
reviewed
Dec 8, 2020
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
eca2dcc
to
b59d6b3
Compare
This adds two methods, PriceDiscovery for getting the configured price discovery, and EstimateGasAndSetFee for doing the gas and fee estimation.
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
b59d6b3
to
780e576
Compare
Ah yes, I forgot about the CLI subcommands, added with tests, thanks! |
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
780e576
to
42336e6
Compare
3 tasks
ptrus
approved these changes
Dec 11, 2020
This makes it more convenient to use the consensus client backend.
Since there are now other actual runtime messages, those can be used instead when testing runtime messages.
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
42336e6
to
62c6866
Compare
tjanez
approved these changes
Dec 11, 2020
kostko
force-pushed
the
kostko/feature/runtime-accounts
branch
from
62c6866
to
4c51f66
Compare
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3429
Fixes #2077
TODO
go/roothash/block/messages.gotogo/roothash/messages.oasis_core_runtime::consensus::*(currently it's directly under common). This includes address, registry, roothash, staking.