Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go tendermint: status peers and validator only after started #3534

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Nov 24, 2020

Otherwise we won't have t.node available.

@pro-wh pro-wh added the c:bug Category: bug label Nov 24, 2020
@pro-wh pro-wh requested a review from kostko November 24, 2020 22:35
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #3534 (aebecfc) into master (52a2199) will increase coverage by 0.15%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3534      +/-   ##
==========================================
+ Coverage   66.46%   66.62%   +0.15%     
==========================================
  Files         373      373              
  Lines       33998    33998              
==========================================
+ Hits        22598    22650      +52     
+ Misses       8139     8083      -56     
- Partials     3261     3265       +4     
Impacted Files Coverage Δ
go/consensus/tendermint/full/full.go 63.51% <85.71%> (+0.26%) ⬆️
.../consensus/tendermint/apps/epochtime_mock/state.go 75.00% <0.00%> (-5.00%) ⬇️
go/storage/mkvs/tree.go 86.95% <0.00%> (-4.35%) ⬇️
go/runtime/client/watcher.go 64.44% <0.00%> (-3.71%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 72.41% <0.00%> (-3.45%) ⬇️
go/storage/api/root_cache.go 78.33% <0.00%> (-3.34%) ⬇️
go/storage/mkvs/insert.go 87.67% <0.00%> (-2.74%) ⬇️
go/storage/database/database.go 68.23% <0.00%> (-2.36%) ⬇️
go/storage/mkvs/lookup.go 74.19% <0.00%> (-2.16%) ⬇️
go/worker/storage/committee/node.go 75.00% <0.00%> (-2.01%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a2199...aebecfc. Read the comment docs.

@pro-wh pro-wh merged commit 2e1f77d into master Nov 26, 2020
@pro-wh pro-wh deleted the pro-wh/bugfix/status branch November 26, 2020 00:05
pro-wh added a commit that referenced this pull request Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants