Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/common: Add LoadEntitySigner() helper #3556

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Dec 8, 2020

Replace LoadEntity() helper with LoadEntitySigner() that requires no arguments and loads the entity directory and obtains the signer backend by itself.

Remove entity directory loading boilerplate code by using this new helper.

Replace LoadEntity() helper with LoadEntitySigner() that requires no
arguments and loads the entity directory and obtains the signer backend by
itself.

Remove entity directory loading boilerplate code by using this new
helper.
@tjanez tjanez added the c:cli Category: command line interface label Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #3556 (84428ba) into master (2c3a473) will decrease coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3556      +/-   ##
==========================================
- Coverage   66.52%   66.50%   -0.03%     
==========================================
  Files         377      377              
  Lines       34296    34273      -23     
==========================================
- Hits        22815    22792      -23     
  Misses       8189     8189              
  Partials     3292     3292              
Impacted Files Coverage Δ
go/oasis-node/cmd/common/common.go 49.60% <40.00%> (-0.40%) ⬇️
go/oasis-node/cmd/registry/entity/entity.go 42.92% <50.00%> (+0.67%) ⬆️
go/oasis-node/cmd/registry/runtime/runtime.go 57.69% <50.00%> (+0.77%) ⬆️
go/oasis-node/cmd/registry/node/node.go 44.35% <66.66%> (+0.44%) ⬆️
go/oasis-node/cmd/common/consensus/consensus.go 42.16% <100.00%> (+1.05%) ⬆️
go/staking/api/grpc.go 52.75% <0.00%> (-6.30%) ⬇️
go/consensus/tendermint/apps/registry/registry.go 57.73% <0.00%> (-5.16%) ⬇️
go/worker/common/committee/runtime_host.go 65.04% <0.00%> (-4.86%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.27% <0.00%> (-4.66%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3a473...84428ba. Read the comment docs.

@tjanez tjanez merged commit 10c49a0 into master Dec 8, 2020
@tjanez tjanez deleted the tjanez/cmd-load-entity-improvements branch December 8, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants