Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show delegations in oasis-node stake account info #3557

Closed
1xCL opened this issue Dec 8, 2020 · 3 comments · Fixed by #3725
Closed

Show delegations in oasis-node stake account info #3557

1xCL opened this issue Dec 8, 2020 · 3 comments · Fixed by #3725
Assignees
Labels
c:cli Category: command line interface

Comments

@1xCL
Copy link

1xCL commented Dec 8, 2020

SUMMARY

oasis-node stake account info returns 0 balances on Escrow Account for a non-validator account.
https://www.oasisscan.com/accounts/detail/oasis1qqs6ylpfurhf6gc9mw232fkmrt3d0673lyzc5xf2

$ oasis-node stake account info -a $ADDR --stake.account.address oasis1qqs6ylpfurhf6gc9mw232fkmrt3d0673lyzc5xf2
General Account:
  Balance: ROSE 148689190.999985
  Nonce:   1
Escrow Account:
  Active:
    Balance:      ROSE 0.0
    Total Shares: 0
  Debonding:
    Balance:      ROSE 0.0
    Total Shares: 0
  Commission Schedule:
    Rates: (none)
    Rate Bounds: (none)
  Stake Accumulator:
    Claims: (none)

On the other hand, a validator account returns the correct balances.
https://www.oasisscan.com/accounts/detail/oasis1qz72lvk2jchk0fjrz7u2swpazj3t5p0edsdv7sf8

$ oasis-node stake account info   -a $ADDR   --stake.account.address oasis1qz72lvk2jchk0fjrz7u2swpazj3t5p0edsdv7sf8
General Account:
  Balance: ROSE 3845.994520821
  Nonce:   7
Escrow Account:
  Active:
    Balance:      ROSE 171584440.736695885
    Total Shares: 167427289728797480
  Debonding:
    Balance:      ROSE 58748.122830794
    Total Shares: 58748122830794
  Commission Schedule:
    Rates:
      (1) start: epoch 23
          rate:  10.0%
      (2) start: epoch 86
          rate:  15.0%
    Rate Bounds:
      (1) start:        epoch 0
          minimum rate: 0.0%
          maximum rate: 20.0%
  Stake Accumulator:
    Claims:
      - Name: registry.RegisterEntity
        Staking Thresholds:
          - Global: entity
      - Name: registry.RegisterNode.aJFHeID4Q7qUfMa42dRwaa9PQrZ/cVDiE3WNt4bQjo0=
        Staking Thresholds:
          - Global: node-validator
ISSUE TYPE
  • Bug Report
COMPONENT NAME
OASIS NODE VERSION
Software version: 20.12.2
Consensus:
  Consensus protocol version: 2.0.0
  Tendermint Core version:    0.34.0
  ABCI library version:       0.17.0
Runtime:
  Host protocol version:      1.0.0
  Committee protocol version: 1.0.0
Go toolchain version: 1.15.5
OS / ENVIRONMENT

Ubuntu 20.10

@kostko
Copy link
Member

kostko commented Dec 8, 2020

Escrow balance only shows the balance of incoming delegations (e.g., amount delegated to that account). On the other hand oasis scan also counts outgoing delegations (e.g., if you delegate to other accounts).

So both the CLI and oasis scan are correct, they just show different things. I think this is where the confusion is coming from.

@kostko
Copy link
Member

kostko commented Dec 8, 2020

I agree that it would be useful if account info also showed the account's outgoing delegations and their total sum.

@kostko kostko added the c:cli Category: command line interface label Dec 8, 2020
@kostko kostko changed the title oasis-node stake account info returns 0 escrow balances for a non-validator account Show delegations in oasis-node stake account info Dec 8, 2020
@1xCL
Copy link
Author

1xCL commented Dec 9, 2020

Thanks that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants