Add ConsensusParameters methods for scheduler/epochtime #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
changed the title
ptrus
force-pushed
the
ptrus/fix/txsource-params-query
branch
2 times, most recently
from
8a0a451
to
94c7bd6
Compare
kostko
reviewed
Dec 11, 2020
go/consensus/api/light.go
Outdated
Comment on lines
46
to
47
| // Consensus are the backend agnostic consensus parameters. | ||
| Consensus genesis.Parameters `json:"consensus"` |
There was a problem hiding this comment.
Suggested change
| // Consensus are the backend agnostic consensus parameters. | |
| Consensus genesis.Parameters `json:"consensus"` | |
| // Parameters are the backend agnostic consensus parameters. | |
| Parameters genesis.Parameters `json:"parameters"` |
Also these should probably be placed above Meta.
ptrus
force-pushed
the
ptrus/fix/txsource-params-query
branch
9 times, most recently
from
e129e3b
to
dcf12d4
Compare
ptrus
requested review from
peterjgilbert,
pro-wh and
Yawning
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3565 +/- ##
==========================================
+ Coverage 66.47% 66.84% +0.36%
==========================================
Files 377 377
Lines 34469 34544 +75
==========================================
+ Hits 22914 23091 +177
+ Misses 8246 8154 -92
+ Partials 3309 3299 -10
Continue to review full report at Codecov.
|
kostko
approved these changes
Dec 14, 2020
go/consensus/tendermint/full/full.go
Outdated
| } | ||
|
|
||
| tmHeight, err := t.heightToTendermintHeight(height) | ||
| if err != nil { |
| @@ -110,6 +110,9 @@ type ClientBackend interface { | |||
| // GetEpoch returns the current epoch. | |||
| GetEpoch(ctx context.Context, height int64) (epochtime.EpochTime, error) | |||
|
|
|||
| // EpochtimeConsensusParameters returns the epochtime consensus parameters. | |||
ptrus
force-pushed
the
ptrus/fix/txsource-params-query
branch
2 times, most recently
from
2015e0a
to
50dbf48
Compare
ptrus
force-pushed
the
ptrus/fix/txsource-params-query
branch
from
50dbf48
to
b304bce
Compare
ptrus
force-pushed
the
ptrus/fix/txsource-params-query
branch
from
b304bce
to
4276b59
Compare
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: