Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/scheduling: Consumer should pull from scheduler #3569

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Dec 15, 2020

Previously the scheduler would push batches to the consumer (e.g. compute
node) which makes no sense as the consumer knows when it's ready to accept
new batches. This changes the model so that the consumer pulls batches from
the scheduler.

@kostko kostko added c:bug Category: bug c:runtime/scheduler Category: runtime txn scheduler labels Dec 15, 2020
@kostko kostko force-pushed the kostko/fix/executor-pull-batch branch 3 times, most recently from b534641 to cce3ae7 Compare December 15, 2020 17:00
@kostko kostko requested a review from ptrus December 15, 2020 17:01
@kostko kostko force-pushed the kostko/fix/executor-pull-batch branch from cce3ae7 to 8aa6a9d Compare December 16, 2020 09:11
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! i think this is indeed much better. Thanks for also noticing & fixing the update config stuff.

Looks good, just two minor comments.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #3569 (7556892) into master (e0f609d) will decrease coverage by 0.08%.
The diff coverage is 71.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3569      +/-   ##
==========================================
- Coverage   66.64%   66.56%   -0.09%     
==========================================
  Files         377      377              
  Lines       34544    34545       +1     
==========================================
- Hits        23022    22995      -27     
- Misses       8216     8226      +10     
- Partials     3306     3324      +18     
Impacted Files Coverage Δ
...scheduling/simple/txpool/orderedmap/ordered_map.go 91.07% <50.00%> (+7.28%) ⬆️
go/worker/compute/executor/committee/node.go 65.45% <70.68%> (+0.83%) ⬆️
go/runtime/scheduling/simple/simple.go 81.39% <77.77%> (+2.70%) ⬆️
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-6.55%) ⬇️
...nsensus/tendermint/apps/staking/signing_rewards.go 20.00% <0.00%> (-5.72%) ⬇️
go/consensus/tendermint/full/services.go 81.35% <0.00%> (-4.24%) ⬇️
go/storage/mkvs/insert.go 87.67% <0.00%> (-4.11%) ⬇️
go/consensus/tendermint/apps/staking/staking.go 51.70% <0.00%> (-2.73%) ⬇️
go/worker/common/committee/node.go 69.68% <0.00%> (-2.66%) ⬇️
go/consensus/tendermint/roothash/roothash.go 71.23% <0.00%> (-2.47%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f609d...7556892. Read the comment docs.

Previously the scheduler would push batches to the consumer (e.g. compute
node) which makes no sense as the consumer knows when it's ready to accept
new batches. This changes the model so that the consumer pulls batches from
the scheduler.
@kostko kostko force-pushed the kostko/fix/executor-pull-batch branch from 8aa6a9d to 7556892 Compare December 16, 2020 09:58
@kostko kostko merged commit 8cf219b into master Dec 16, 2020
@kostko kostko deleted the kostko/fix/executor-pull-batch branch December 16, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:runtime/scheduler Category: runtime txn scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants