-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/runtime/scheduling: Consumer should pull from scheduler #3569
Conversation
b534641
to
cce3ae7
Compare
cce3ae7
to
8aa6a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! i think this is indeed much better. Thanks for also noticing & fixing the update config stuff.
Looks good, just two minor comments.
Codecov Report
@@ Coverage Diff @@
## master #3569 +/- ##
==========================================
- Coverage 66.64% 66.56% -0.09%
==========================================
Files 377 377
Lines 34544 34545 +1
==========================================
- Hits 23022 22995 -27
- Misses 8216 8226 +10
- Partials 3306 3324 +18
Continue to review full report at Codecov.
|
Previously the scheduler would push batches to the consumer (e.g. compute node) which makes no sense as the consumer knows when it's ready to accept new batches. This changes the model so that the consumer pulls batches from the scheduler.
8aa6a9d
to
7556892
Compare
Previously the scheduler would push batches to the consumer (e.g. compute
node) which makes no sense as the consumer knows when it's ready to accept
new batches. This changes the model so that the consumer pulls batches from
the scheduler.