Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd: Fix output of stake account validate_address cmd #3589

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Dec 21, 2020

Add missing newline to the verbose output when the account address is valid.

@tjanez tjanez added c:staking Category: staking c:cli Category: command line interface labels Dec 21, 2020
@tjanez tjanez force-pushed the tjanez/fix-cli-stake-account-validate branch from bdf5abc to f9a21e0 Compare December 21, 2020 13:45
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #3589 (f9a21e0) into master (7e19cd8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3589      +/-   ##
==========================================
+ Coverage   66.58%   66.60%   +0.02%     
==========================================
  Files         377      377              
  Lines       34562    34562              
==========================================
+ Hits        23013    23021       +8     
+ Misses       8230     8226       -4     
+ Partials     3319     3315       -4     
Impacted Files Coverage Δ
go/oasis-node/cmd/stake/account.go 54.71% <100.00%> (ø)
go/consensus/tendermint/api/api.go 74.66% <0.00%> (-10.67%) ⬇️
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/worker/common/committee/node.go 72.34% <0.00%> (-6.39%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 75.00% <0.00%> (-5.00%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.49% <0.00%> (-4.39%) ⬇️
go/consensus/tendermint/full/light.go 48.93% <0.00%> (-4.26%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.13% <0.00%> (-3.78%) ⬇️
go/storage/mkvs/lookup.go 72.04% <0.00%> (-2.16%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 72.76% <0.00%> (-1.95%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36d036...8f0908c. Read the comment docs.

Add missing newline to the verbose output when the account address is
valid.
@tjanez tjanez force-pushed the tjanez/fix-cli-stake-account-validate branch from f9a21e0 to 8f0908c Compare December 21, 2020 15:28
@tjanez tjanez merged commit 36fd6c8 into master Dec 21, 2020
@tjanez tjanez deleted the tjanez/fix-cli-stake-account-validate branch January 5, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface c:staking Category: staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants