Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/storage/mkvs: Add MKVS impl for &mut T #3604

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 8, 2021

Trivial MKVS trait impl needed by the ParaTime SDK.

@kostko kostko force-pushed the kostko/feature/mkvs-refmut-impl branch from 19b4c85 to e87d79e Compare January 8, 2021 19:54
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #3604 (e87d79e) into master (205e569) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3604      +/-   ##
==========================================
- Coverage   67.25%   67.17%   -0.08%     
==========================================
  Files         390      390              
  Lines       36507    36507              
==========================================
- Hits        24552    24523      -29     
- Misses       8498     8522      +24     
- Partials     3457     3462       +5     
Impacted Files Coverage Δ
go/consensus/tendermint/apps/governance/query.go 81.81% <0.00%> (-18.19%) ⬇️
go/consensus/tendermint/full/services.go 78.81% <0.00%> (-6.78%) ⬇️
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-6.55%) ⬇️
go/storage/mkvs/insert.go 87.67% <0.00%> (-5.48%) ⬇️
go/runtime/nodes/grpc/grpc.go 71.08% <0.00%> (-5.23%) ⬇️
go/worker/upgrade/worker.go 67.70% <0.00%> (-5.21%) ⬇️
go/keymanager/client/client.go 77.19% <0.00%> (-4.39%) ⬇️
go/storage/mkvs/tree.go 86.95% <0.00%> (-4.35%) ⬇️
go/storage/api/root_cache.go 78.33% <0.00%> (-3.34%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 74.28% <0.00%> (-2.86%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205e569...e87d79e. Read the comment docs.

@kostko kostko enabled auto-merge January 9, 2021 20:58
@kostko kostko disabled auto-merge January 11, 2021 08:58
@kostko kostko merged commit 8039923 into master Jan 11, 2021
@kostko kostko deleted the kostko/feature/mkvs-refmut-impl branch January 11, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants