Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/e2e/governance-upgrade: wait for compute nodes to be ready #3618

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jan 12, 2021

This should help with the governance-upgrade test flakiness where the runtime client request would be sent before the compute nodes were ready (related to: #3599 as compute nodes take a bit more time to get initialized after a restart now).

@ptrus ptrus force-pushed the ptrus/fix/e2e-governance-upgrade branch 3 times, most recently from 7d07e3f to b868ace Compare January 12, 2021 11:03
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #3618 (b868ace) into master (37c096d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3618      +/-   ##
==========================================
+ Coverage   67.35%   67.37%   +0.01%     
==========================================
  Files         390      390              
  Lines       36540    36540              
==========================================
+ Hits        24613    24618       +5     
+ Misses       8482     8474       -8     
- Partials     3445     3448       +3     
Impacted Files Coverage Δ
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
...nsensus/tendermint/apps/staking/signing_rewards.go 20.00% <0.00%> (-5.72%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 56.58% <0.00%> (-5.43%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 73.92% <0.00%> (-2.73%) ⬇️
go/consensus/tendermint/apps/staking/staking.go 53.06% <0.00%> (-2.73%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.27% <0.00%> (-2.33%) ⬇️
go/consensus/tendermint/apps/registry/genesis.go 38.67% <0.00%> (-1.89%) ⬇️
go/roothash/api/commitment/pool.go 71.02% <0.00%> (-1.87%) ⬇️
go/worker/common/committee/runtime_host.go 64.28% <0.00%> (-1.79%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 47.82% <0.00%> (-1.45%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c096d...737350e. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/fix/e2e-governance-upgrade branch from b868ace to 07b8c5c Compare January 12, 2021 12:26
@ptrus ptrus enabled auto-merge January 12, 2021 12:33
@ptrus ptrus force-pushed the ptrus/fix/e2e-governance-upgrade branch from 07b8c5c to 737350e Compare January 12, 2021 12:49
@ptrus ptrus merged commit 660af9d into master Jan 12, 2021
@ptrus ptrus deleted the ptrus/fix/e2e-governance-upgrade branch April 16, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants