Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-test-runner/txsource: Decrease MinPoolSize for restarts #3636

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 19, 2021

When restarts are enabled there can be one less node so we should make sure to
decrease the MinPoolSize in this case.

@kostko kostko added c:testing Category: testing c:bug Category: bug labels Jan 19, 2021
@kostko kostko requested a review from ptrus January 19, 2021 11:37
@kostko kostko enabled auto-merge January 19, 2021 11:41
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #3636 (590f6ff) into master (a235ca4) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3636      +/-   ##
==========================================
- Coverage   67.38%   67.29%   -0.10%     
==========================================
  Files         390      390              
  Lines       36676    36676              
==========================================
- Hits        24715    24680      -35     
- Misses       8505     8542      +37     
+ Partials     3456     3454       -2     
Impacted Files Coverage Δ
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/consensus/tendermint/full/services.go 77.11% <0.00%> (-8.48%) ⬇️
go/common/cbor/codec.go 76.47% <0.00%> (-5.89%) ⬇️
go/storage/mkvs/tree.go 86.95% <0.00%> (-4.35%) ⬇️
go/storage/mkvs/lookup.go 72.04% <0.00%> (-4.31%) ⬇️
go/consensus/tendermint/full/light.go 48.93% <0.00%> (-4.26%) ⬇️
go/storage/mkvs/insert.go 87.67% <0.00%> (-4.11%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.13% <0.00%> (-3.78%) ⬇️
go/staking/api/grpc.go 54.81% <0.00%> (-3.71%) ⬇️
go/worker/common/committee/node.go 70.61% <0.00%> (-3.61%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a235ca4...ed033d9. Read the comment docs.

When restarts are enabled there can be one less node so we should make sure to
decrease the MinPoolSize in this case.
@kostko kostko force-pushed the kostko/fix/e2e-txsource-minpool branch from 590f6ff to ed033d9 Compare January 19, 2021 16:00
@kostko kostko merged commit 2460c56 into master Jan 19, 2021
@kostko kostko deleted the kostko/fix/e2e-txsource-minpool branch January 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants