Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slashing: rename DoubleSigning to ConsensusEquivocation #3646

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jan 21, 2021

Extracted some general slashing changes from: #3640 (ADR-0005)

  • rename DoubleSigning->ConsensusEquivocation
  • change SlashReason type to uint8
  • change SlashEscrow method to return slashed amount

@ptrus ptrus force-pushed the ptrus/feature/consensus-equivocation branch from ed8be35 to 21ae094 Compare January 21, 2021 14:18
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #3646 (dc19eb2) into master (5f6c0bf) will decrease coverage by 0.11%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3646      +/-   ##
==========================================
- Coverage   67.39%   67.27%   -0.12%     
==========================================
  Files         390      390              
  Lines       36676    36678       +2     
==========================================
- Hits        24717    24676      -41     
- Misses       8508     8545      +37     
- Partials     3451     3457       +6     
Impacted Files Coverage Δ
go/consensus/tendermint/apps/staking/staking.go 53.06% <0.00%> (ø)
go/consensus/tendermint/tests/evidence.go 92.72% <ø> (ø)
...o/consensus/tendermint/apps/staking/state/state.go 57.49% <21.42%> (-0.22%) ⬇️
go/consensus/tendermint/crypto/priv_val.go 44.30% <50.00%> (ø)
go/staking/api/slashing.go 77.77% <66.66%> (ø)
go/consensus/tendermint/apps/staking/slashing.go 73.77% <100.00%> (ø)
go/staking/tests/debug/debug_stake.go 92.45% <100.00%> (ø)
go/staking/tests/tester.go 89.39% <100.00%> (ø)
go/consensus/tendermint/apps/governance/query.go 83.33% <0.00%> (-16.67%) ⬇️
go/consensus/tendermint/api/api.go 74.66% <0.00%> (-10.67%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6c0bf...dc19eb2. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/consensus-equivocation branch 5 times, most recently from f5e5ace to 6718060 Compare January 21, 2021 17:53
@ptrus ptrus force-pushed the ptrus/feature/consensus-equivocation branch from 6718060 to dc19eb2 Compare January 22, 2021 08:06
@ptrus ptrus merged commit b11f535 into master Jan 22, 2021
@ptrus ptrus deleted the ptrus/feature/consensus-equivocation branch January 22, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants