Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Fix nil deref in EstimateGas #3648

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 23, 2021

Fixes #3647.

@kostko kostko force-pushed the kostko/fix/mux-estimategas-nil-tx branch from 0c51253 to f23b6cb Compare January 23, 2021 20:14
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #3648 (f23b6cb) into master (b11f535) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3648      +/-   ##
==========================================
- Coverage   67.15%   67.14%   -0.01%     
==========================================
  Files         390      390              
  Lines       36678    36682       +4     
==========================================
  Hits        24631    24631              
- Misses       8574     8576       +2     
- Partials     3473     3475       +2     
Impacted Files Coverage Δ
go/consensus/api/api.go 14.28% <ø> (ø)
go/consensus/tendermint/abci/mux.go 57.97% <100.00%> (+0.55%) ⬆️
go/consensus/tests/tester.go 98.14% <100.00%> (+0.03%) ⬆️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-6.55%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.27% <0.00%> (-4.66%) ⬇️
go/storage/mkvs/iterator.go 80.29% <0.00%> (-2.92%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 73.92% <0.00%> (-2.73%) ⬇️
go/runtime/transaction/transaction.go 72.36% <0.00%> (-2.64%) ⬇️
go/storage/mkvs/lookup.go 72.04% <0.00%> (-2.16%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11f535...f23b6cb. Read the comment docs.

@kostko kostko merged commit 33204e7 into master Jan 25, 2021
@kostko kostko deleted the kostko/fix/mux-estimategas-nil-tx branch January 25, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoking EstimateGas with nil parameter crashes the node
2 participants