Client node support for hosting runtimes #3653

kostko · 2021-01-26T11:59:13Z

TODO

Move runtime host configuration to the runtime registry.
Support the client node hosting runtimes.
Support for provisioner remapping (a client node may use a non-TEE version of the runtime to perform local queries for public state against a runtime which runs in a TEE on executor nodes).
Describe all configuration changes.

codecov · 2021-01-26T13:40:12Z

Codecov Report

Merging #3653 (80710c8) into master (0036da8) will decrease coverage by 0.15%.
The diff coverage is 54.71%.

@@            Coverage Diff             @@
##           master    #3653      +/-   ##
==========================================
- Coverage   66.78%   66.63%   -0.16%     
==========================================
  Files         391      393       +2     
  Lines       38138    38258     +120     
==========================================
+ Hits        25472    25492      +20     
- Misses       9017     9091      +74     
- Partials     3649     3675      +26

Impacted Files	Coverage Δ
go/runtime/client/api/grpc.go	`61.30% <ø> (ø)`
go/worker/common/config.go	`60.60% <ø> (-1.02%)`	⬇️
go/worker/keymanager/worker.go	`63.86% <ø> (ø)`
go/worker/compute/executor/committee/node.go	`66.51% <30.00%> (+1.51%)`	⬆️
go/runtime/client/host.go	`34.21% <34.21%> (ø)`
go/oasis-node/cmd/node/node.go	`53.31% <50.00%> (-1.93%)`	⬇️
go/runtime/host/helpers.go	`52.38% <52.38%> (ø)`
go/runtime/registry/registry.go	`70.93% <60.86%> (-1.05%)`	⬇️
go/runtime/client/client.go	`65.68% <62.50%> (-0.57%)`	⬇️
go/runtime/registry/config.go	`68.26% <64.47%> (-10.31%)`	⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0036da8...f386f83. Read the comment docs.

go/runtime/client/host.go

pro-wh · 2021-02-01T18:18:59Z

go/runtime/host/helpers.go

+
+// RichRuntime provides higher-level functions for talking with a runtime.
+type RichRuntime interface {
+	Runtime


what are the cases where we'll use Runtime instead of RichRuntime?

I was thinking about that as well. Probably RichRuntime would mostly be used and it could just be merged into Runtime. But we also wouldn't want each Runtime implementation to implement all of these wrappers. Maybe we could just provide a BaseRuntime with the wrapper implementations?

Okay yeah. I guess since we don't have plans to have a different implementation of CheckTx, all we have to gain that way is the code being more direct.

feel free to split this out

go/runtime/client/host.go

pro-wh

thanks for the explanations. lg

pro-wh · 2021-02-02T18:06:22Z

go/runtime/host/helpers.go

+
+// RichRuntime provides higher-level functions for talking with a runtime.
+type RichRuntime interface {
+	Runtime


feel free to split this out

Since the PVSS random beacon nodes may be ineligible for committee election on first registration if they register after the commit phase. This adds an extra epoch transition to the E2E test.

kostko added c:runtime/compute Category: runtime compute worker c:breaking/cfg Category: breaks configuration labels Jan 26, 2021

kostko force-pushed the kostko/feature/rt-client-side branch 2 times, most recently from 4567b8e to 11d0093 Compare January 26, 2021 13:18

kostko force-pushed the kostko/feature/rt-client-side branch 5 times, most recently from 57ff8f6 to 8509b23 Compare January 28, 2021 11:45

kostko marked this pull request as ready for review January 28, 2021 11:46

kostko requested review from peterjgilbert, pro-wh, ptrus and Yawning as code owners January 28, 2021 11:46

kostko mentioned this pull request Jan 29, 2021

runtime: Add support for runtime queries #3662

Merged

kostko force-pushed the kostko/feature/rt-client-side branch 2 times, most recently from c17d9e1 to b9a4c6b Compare February 1, 2021 14:02

pro-wh reviewed Feb 1, 2021

View reviewed changes

kostko force-pushed the kostko/feature/rt-client-side branch 2 times, most recently from 5b174c3 to 80710c8 Compare February 2, 2021 09:52

pro-wh approved these changes Feb 2, 2021

View reviewed changes

kostko added 5 commits February 3, 2021 13:26

go/runtime: Move host configuration to runtime registry

7b94288

go/runtime/client: Support hosting runtimes

9855edb

go/runtime/host: Add helpers for common requests

7165e74

go/runtime/client: Perform local CheckTx when a hosted runtime exists

c1fefdf

e2e/runtime/runtime-dynamic: Ensure nodes are eligible for election

f386f83

Since the PVSS random beacon nodes may be ineligible for committee election on first registration if they register after the commit phase. This adds an extra epoch transition to the E2E test.

kostko force-pushed the kostko/feature/rt-client-side branch from 80710c8 to f386f83 Compare February 3, 2021 12:27

kostko enabled auto-merge February 3, 2021 12:27

kostko merged commit 9e37cea into master Feb 3, 2021

kostko deleted the kostko/feature/rt-client-side branch February 3, 2021 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client node support for hosting runtimes #3653

Client node support for hosting runtimes #3653

kostko commented Jan 26, 2021 •

edited

codecov bot commented Jan 26, 2021 •

edited

pro-wh Feb 1, 2021

kostko Feb 1, 2021 •

edited

pro-wh Feb 1, 2021

pro-wh Feb 2, 2021

pro-wh left a comment

pro-wh Feb 2, 2021

Client node support for hosting runtimes #3653

Client node support for hosting runtimes #3653

Conversation

kostko commented Jan 26, 2021 • edited

codecov bot commented Jan 26, 2021 • edited

Codecov Report

pro-wh Feb 1, 2021

Choose a reason for hiding this comment

kostko Feb 1, 2021 • edited

Choose a reason for hiding this comment

pro-wh Feb 1, 2021

Choose a reason for hiding this comment

pro-wh Feb 2, 2021

Choose a reason for hiding this comment

pro-wh left a comment

Choose a reason for hiding this comment

pro-wh Feb 2, 2021

Choose a reason for hiding this comment

kostko commented Jan 26, 2021 •

edited

codecov bot commented Jan 26, 2021 •

edited

kostko Feb 1, 2021 •

edited