Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beacon: Add a gRPC service #3666

Closed
Yawning opened this issue Feb 1, 2021 · 0 comments · Fixed by #3683
Closed

beacon: Add a gRPC service #3666

Yawning opened this issue Feb 1, 2021 · 0 comments · Fixed by #3683
Assignees
@Yawning
Labels
c:beacon Category: random beacon service

Comments

@Yawning
Copy link
Contributor

Yawning commented Feb 1, 2021

go/consensus/api/api.go currently has an ugly hack in the form of BeaconConsensusParameters. While I question the "add gRPC services for absolutely everything" approach, for consistency with the rest of the codebase, the beacon could expose a gRPC service with a ConsensusParameters call.
@Yawning Yawning added the golang label Feb 1, 2021
@Yawning Yawning mentioned this issue Feb 1, 2021
Merged
21 tasks
@kostko kostko added c:beacon Category: random beacon service and removed golang labels Feb 2, 2021
@Yawning Yawning mentioned this issue Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yawning Yawning

Labels
c:beacon Category: random beacon service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

beacon: Add a minimal gRPC service oasisprotocol/oasis-core
2 participants
@kostko @Yawning