Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon: Transaction handling fixes #3675

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 3, 2021

  • go/consensus: Add support for method priority

  • go/beacon: Make beacon methods critical and ignore tx authentication

    There is no sense in handling transaction authentication and fees for beacon
    methods which can only be invoked by the block proposer.

  • e2e/runtime: Also configure intervals for PVSS backend

  • go/beacon: Only allow a single beacon transaction per block

@kostko kostko added the c:beacon Category: random beacon service label Feb 3, 2021
@kostko kostko force-pushed the kostko/fix/beacon-e2e-tests branch from 6420fb3 to 46851ca Compare February 3, 2021 12:25
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #3675 (46851ca) into master (30110a5) will increase coverage by 0.05%.
The diff coverage is 65.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3675      +/-   ##
==========================================
+ Coverage   66.64%   66.69%   +0.05%     
==========================================
  Files         393      391       -2     
  Lines       38366    38160     -206     
==========================================
- Hits        25569    25451     -118     
+ Misses       9120     9049      -71     
+ Partials     3677     3660      -17     
Impacted Files Coverage Δ
go/consensus/tendermint/api/api.go 82.89% <0.00%> (-1.11%) ⬇️
go/oasis-node/cmd/genesis/genesis.go 53.99% <ø> (-0.10%) ⬇️
go/consensus/tendermint/abci/mux.go 57.64% <33.33%> (-1.09%) ⬇️
...o/consensus/tendermint/apps/beacon/backend_pvss.go 59.56% <64.70%> (-0.27%) ⬇️
.../consensus/tendermint/apps/registry/state/state.go 57.05% <71.42%> (+0.53%) ⬆️
go/beacon/api/pvss.go 80.00% <100.00%> (+5.00%) ⬆️
go/consensus/api/transaction/transaction.go 55.91% <100.00%> (+3.04%) ⬆️
go/consensus/api/transaction/results/results.go 0.00% <0.00%> (-100.00%) ⬇️
go/worker/storage/service_external.go 40.74% <0.00%> (-11.12%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278c54b...4d27e86. Read the comment docs.

@kostko kostko marked this pull request as ready for review February 3, 2021 13:01
@kostko kostko force-pushed the kostko/fix/beacon-e2e-tests branch from 46851ca to 4d27e86 Compare February 3, 2021 19:39
@kostko kostko enabled auto-merge February 3, 2021 19:39
@kostko kostko merged commit 60545db into master Feb 3, 2021
@kostko kostko deleted the kostko/fix/beacon-e2e-tests branch February 3, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:beacon Category: random beacon service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants