Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/common/metrics: Fix label escaping #3678

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 4, 2021

No description provided.

Copy link
Contributor

@gw0 gw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue at hand, but maybe an allowlist approach would be better?

go/oasis-node/cmd/common/metrics/metrics.go Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/fix/e2e-metrics-label-escape branch from c327ba9 to 65dd18a Compare February 4, 2021 08:58
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #3678 (61a803c) into master (60545db) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3678      +/-   ##
==========================================
- Coverage   66.76%   66.73%   -0.04%     
==========================================
  Files         393      393              
  Lines       38388    38388              
==========================================
- Hits        25631    25618      -13     
- Misses       9087     9090       +3     
- Partials     3670     3680      +10     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/metrics/metrics.go 18.11% <100.00%> (+0.78%) ⬆️
go/consensus/tendermint/apps/governance/query.go 83.33% <0.00%> (-16.67%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/worker/upgrade/worker.go 67.70% <0.00%> (-5.21%) ⬇️
go/storage/mkvs/tree.go 86.95% <0.00%> (-4.35%) ⬇️
go/consensus/tendermint/full/light.go 48.93% <0.00%> (-4.26%) ⬇️
go/consensus/tendermint/full/services.go 80.00% <0.00%> (-4.17%) ⬇️
go/worker/common/committee/node.go 70.61% <0.00%> (-3.61%) ⬇️
go/storage/api/root_cache.go 78.33% <0.00%> (-3.34%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 71.25% <0.00%> (-2.50%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60545db...61a803c. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/e2e-metrics-label-escape branch from 65dd18a to 61a803c Compare February 4, 2021 10:37
@kostko kostko merged commit 65b7e6b into master Feb 4, 2021
@kostko kostko deleted the kostko/fix/e2e-metrics-label-escape branch February 4, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants