Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/registry: Change minimum ProposerTimeout from 5 to 2 blocks #3682

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 8, 2021

No description provided.

@kostko kostko force-pushed the kostko/fix/rt-txn-prop-timeout-min branch from 5e325fc to 7d57ffd Compare February 8, 2021 09:32
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #3682 (7d57ffd) into master (8187e2c) will increase coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3682      +/-   ##
==========================================
+ Coverage   66.67%   66.92%   +0.25%     
==========================================
  Files         393      393              
  Lines       38370    38373       +3     
==========================================
+ Hits        25582    25681      +99     
+ Misses       9107     9034      -73     
+ Partials     3681     3658      -23     
Impacted Files Coverage Δ
go/oasis-node/cmd/registry/runtime/runtime.go 58.55% <0.00%> (-0.59%) ⬇️
go/registry/api/runtime.go 45.85% <0.00%> (ø)
go/worker/storage/service_external.go 40.74% <0.00%> (-7.41%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 62.50% <0.00%> (-6.25%) ⬇️
go/storage/api/metrics.go 86.15% <0.00%> (-4.62%) ⬇️
go/storage/mkvs/prefetch.go 54.71% <0.00%> (-3.78%) ⬇️
go/consensus/tendermint/abci/state.go 71.83% <0.00%> (-1.77%) ⬇️
go/keymanager/client/client.go 81.57% <0.00%> (-1.76%) ⬇️
go/runtime/nodes/grpc/grpc.go 72.69% <0.00%> (-1.61%) ⬇️
go/runtime/client/watcher.go 62.96% <0.00%> (-1.49%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8187e2c...7d57ffd. Read the comment docs.

@kostko kostko enabled auto-merge February 8, 2021 10:37
@kostko kostko merged commit 9cdfa91 into master Feb 9, 2021
@kostko kostko deleted the kostko/fix/rt-txn-prop-timeout-min branch February 9, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants