go/worker/storage: Add StorageRPC role and change access policy #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
reviewed
Feb 11, 2021
jberci
force-pushed
the
jberci/feature/storage-policy
branch
9 times, most recently
from
b721fc9
to
6a42295
Compare
Codecov Report
@@ Coverage Diff @@
## master #3696 +/- ##
==========================================
- Coverage 66.50% 66.45% -0.06%
==========================================
Files 400 399 -1
Lines 39654 39582 -72
==========================================
- Hits 26372 26303 -69
+ Misses 9516 9497 -19
- Partials 3766 3782 +16
Continue to review full report at Codecov.
|
jberci
force-pushed
the
jberci/feature/storage-policy
branch
from
6a42295
to
5412fbc
Compare
jberci
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
kostko
reviewed
Feb 17, 2021
| } | ||
|
|
||
| // If not configured otherwise, state access should be restricted to storage committee members. | ||
| default: |
There was a problem hiding this comment.
Why is this part not covered? Are we not testing with any storage nodes that don't expose public RPC? We should test those as well (e.g., configure a storage node without public RPC exposed). Maybe in cases where we have two storage nodes, set one to expose public RPC and the other to not expose it?
ptrus
reviewed
Feb 17, 2021
ptrus
reviewed
Feb 17, 2021
jberci
force-pushed
the
jberci/feature/storage-policy
branch
2 times, most recently
from
a914a7d
to
4f4e0a5
Compare
kostko
reviewed
Feb 18, 2021
Getting checkpoints and diffs is now allowed for any connecting node, which eliminates a race condition and initialization difficulty in the storage committee node startup. State access is made gated but optionally public as before, depending on command line parameters.
jberci
force-pushed
the
jberci/feature/storage-policy
branch
from
4f4e0a5
to
267b902
Compare
kostko
approved these changes
Feb 18, 2021
ptrus
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting checkpoints and diffs is now allowed for any connecting node,
which eliminates a race condition and initialization difficulty in the
storage committee node startup.
State access is made gated but optionally public as before, depending on
command line parameters.
Closes #3562