runtime: Provide sets of good and bad compute nodes in round results #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
added
c:runtime/compute
kostko
force-pushed
the
kostko/feature/rt-committee-info
branch
from
5b23d6c
to
b36439e
Compare
kostko
force-pushed
the
kostko/feature/rt-committee-info
branch
from
b36439e
to
589c6a9
Compare
kostko
requested review from
peterjgilbert,
pro-wh and
Yawning
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3726 +/- ##
==========================================
- Coverage 66.93% 66.83% -0.11%
==========================================
Files 400 400
Lines 39822 39829 +7
==========================================
- Hits 26656 26619 -37
- Misses 9401 9434 +33
- Partials 3765 3776 +11
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/rt-committee-info
branch
from
589c6a9
to
dc4effe
Compare
ptrus
reviewed
Feb 24, 2021
go/roothash/api/history.go
Outdated
|
|
||
| // GoodComputeNodes are the public keys of compute nodes that positively contributed to the | ||
| // round by replicating the computation correctly. | ||
| GoodComputeNodes []signature.PublicKey `json:"good_compute_nodes,omitempty"` |
There was a problem hiding this comment.
Wondering if there's a better alternative naming to use for nodes that submitted correct and invalid results. I thought about it, but don't have a better suggestion though :D
There was a problem hiding this comment.
Yeah, I was thinking about how to name this as well, but didn't come up with anything better. Tendermint uses the term "Byzantine Validators" for the bad ones.
ptrus
reviewed
Feb 24, 2021
ptrus
reviewed
Feb 24, 2021
| @@ -587,50 +591,41 @@ func (app *rootHashApplication) tryFinalizeExecutorCommits( | |||
| return fmt.Errorf("failed to process runtime messages: %w", err) | |||
| } | |||
|
|
|||
| var ( | |||
ptrus
approved these changes
Feb 24, 2021
kostko
force-pushed
the
kostko/feature/rt-committee-info
branch
from
dc4effe
to
174b48a
Compare
kostko
force-pushed
the
kostko/feature/rt-committee-info
branch
3 times, most recently
from
f993cfd
to
98e7097
Compare
In addition to the existing runtime message execution results we want to provide additional information about the last successful round to runtimes. This introduces a RoundResults structure for this purpose.
Previously only incorrect primary members were slashed and correct backup members were rewarded. Now, any incorrect members are slashed and any correct members are rewarded.
This allows the runtime to be aware of how many runtime messages can be emitted in this round before the round would fail.
kostko
force-pushed
the
kostko/feature/rt-committee-info
branch
from
98e7097
to
289309d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.