Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus: Store runtime state roots in a single key #3782

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 15, 2021

That makes it easier to construct proofs starting at the consensus state root
that prove what the state root of a specific runtime is. You can then chain
these proofs to prove something about runtime state.

@kostko kostko added c:roothash Category: root hash service c:breaking/consensus Category: breaking consensus changes labels Mar 15, 2021
@kostko kostko force-pushed the kostko/feature/roothash-rt-quick-state-root branch from c46d05d to 2890553 Compare March 15, 2021 19:39
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #3782 (28586d0) into master (7d0d54b) will decrease coverage by 0.07%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3782      +/-   ##
==========================================
- Coverage   67.32%   67.24%   -0.08%     
==========================================
  Files         402      402              
  Lines       40560    40569       +9     
==========================================
- Hits        27305    27281      -24     
- Misses       9410     9427      +17     
- Partials     3845     3861      +16     
Impacted Files Coverage Δ
.../consensus/tendermint/apps/roothash/state/state.go 68.64% <40.00%> (-6.36%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/storage/api/root_cache.go 71.11% <0.00%> (-4.45%) ⬇️
go/storage/mkvs/tree.go 86.95% <0.00%> (-4.35%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.19% <0.00%> (-4.29%) ⬇️
go/consensus/tendermint/full/services.go 80.00% <0.00%> (-4.17%) ⬇️
go/consensus/tendermint/roothash/roothash.go 69.03% <0.00%> (-3.81%) ⬇️
go/runtime/host/sgx/sgx.go 71.42% <0.00%> (-3.30%) ⬇️
go/storage/mkvs/insert.go 87.67% <0.00%> (-2.74%) ⬇️
...consensus/tendermint/apps/scheduler/state/state.go 62.22% <0.00%> (-2.23%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06b845...fec78f0. Read the comment docs.

@kostko kostko marked this pull request as ready for review March 15, 2021 20:29
@kostko kostko force-pushed the kostko/feature/roothash-rt-quick-state-root branch 2 times, most recently from bc2e1e5 to 5f830e7 Compare March 16, 2021 09:10
@kostko kostko force-pushed the kostko/feature/roothash-rt-quick-state-root branch from 5f830e7 to 28586d0 Compare March 16, 2021 09:21
That makes it easier to construct proofs starting at the consensus state root
that prove what the state root of a specific runtime is. You can then chain
these proofs to prove something about runtime state.
@kostko kostko force-pushed the kostko/feature/roothash-rt-quick-state-root branch from 28586d0 to fec78f0 Compare March 16, 2021 12:00
@kostko kostko enabled auto-merge March 16, 2021 12:01
@kostko kostko merged commit ac7e3d1 into master Mar 16, 2021
@kostko kostko deleted the kostko/feature/roothash-rt-quick-state-root branch March 16, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:roothash Category: root hash service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants