Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/roothash/reindexBlocks: return latest known round if no new rounds are reindexed #3791

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 17, 2021

This fixes a case where a storage node would not register if restarted while synced and there were no new runtime rounds (e.g. the runtime is suspended).

Also updates the runtime-dynamic scenario to test this case.

@ptrus ptrus force-pushed the ptrus/fix/storage-register branch 2 times, most recently from b162ebf to 0b9b27f Compare March 17, 2021 12:30
@kostko kostko added the c:roothash Category: root hash service label Mar 17, 2021
@ptrus ptrus force-pushed the ptrus/fix/storage-register branch from 0b9b27f to 0222dda Compare March 17, 2021 12:57
@ptrus ptrus force-pushed the ptrus/fix/storage-register branch from 0222dda to 5bb676e Compare March 17, 2021 13:14
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #3791 (5bb676e) into master (a1120a7) will decrease coverage by 0.16%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3791      +/-   ##
==========================================
- Coverage   67.27%   67.10%   -0.17%     
==========================================
  Files         403      403              
  Lines       40904    40912       +8     
==========================================
- Hits        27518    27454      -64     
- Misses       9498     9567      +69     
- Partials     3888     3891       +3     
Impacted Files Coverage Δ
go/consensus/tendermint/roothash/roothash.go 67.16% <75.00%> (-6.19%) ⬇️
go/runtime/host/sandbox/sandbox.go 69.53% <0.00%> (-12.11%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 69.23% <0.00%> (-7.70%) ⬇️
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-6.55%) ⬇️
go/worker/common/committee/runtime_host.go 64.28% <0.00%> (-6.25%) ⬇️
go/consensus/api/submission.go 67.10% <0.00%> (-5.27%) ⬇️
go/storage/api/root_cache.go 71.11% <0.00%> (-4.45%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 73.49% <0.00%> (-2.82%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1120a7...5bb676e. Read the comment docs.

@ptrus ptrus merged commit 9df8f95 into master Mar 17, 2021
@ptrus ptrus deleted the ptrus/fix/storage-register branch March 17, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:roothash Category: root hash service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants