Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IORoot from GetTxsRequest #3812

Closed
kostko opened this issue Mar 23, 2021 · 1 comment · Fixed by #3982
Closed

Remove IORoot from GetTxsRequest #3812

kostko opened this issue Mar 23, 2021 · 1 comment · Fixed by #3982
Assignees
@kostko
Labels
c:client Category: client interface
Projects
Core 21.2

Comments

@kostko
Copy link
Member

kostko commented Mar 23, 2021

Currently the GetTxs request in the runtime client requires the caller to first fetch the block to get the IORoot and pass that in the request. This should be changed to behave similarly to GetEvents where the block is fetched internally.
@kostko kostko added the c:client Category: client interface label Mar 23, 2021
@kostko kostko added this to Planned in Core 21.2 via automation Mar 23, 2021
@kostko kostko added the c:breaking Category: breaking code change label May 14, 2021
@kostko kostko self-assigned this Jun 1, 2021
@kostko kostko moved this from Planned to In Progress in Core 21.2 Jun 1, 2021
@kostko
Copy link
Member Author

kostko commented Jun 1, 2021

Instead of changing the existing method, let's just introduce a new one called GetTransactions (to be consistent with the consensus API) and deprecate the old one (we can remove it in the next major version).

@kostko kostko removed the c:breaking Category: breaking code change label Jun 1, 2021
@kostko kostko linked a pull request Jun 1, 2021 that will close this issue
go/runtime/client: Add GetTransactions method, deprecate GetTxs #3982
Merged
@kostko kostko mentioned this issue Jun 1, 2021
Closed
Core 21.2 automation moved this from In Progress to Done Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:client Category: client interface
Projects
No open projects
Core 21.2
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/runtime/client: Add GetTransactions method, deprecate GetTxs oasisprotocol/oasis-core
1 participant
@kostko