Fix storage worker #3820
Merged
Fix storage worker #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberci
force-pushed
the
jberci/fix/storage
branch
from
24a416e
to
488f863
Compare
kostko
reviewed
Mar 30, 2021
jberci
force-pushed
the
jberci/fix/storage
branch
from
20b00a9
to
f6a7f15
Compare
Codecov Report
@@ Coverage Diff @@
## master #3820 +/- ##
==========================================
- Coverage 67.27% 67.22% -0.05%
==========================================
Files 404 404
Lines 40889 40952 +63
==========================================
+ Hits 27508 27530 +22
- Misses 9512 9541 +29
- Partials 3869 3881 +12
Continue to review full report at Codecov.
|
jberci
force-pushed
the
jberci/fix/storage
branch
from
f6a7f15
to
e89db28
Compare
jberci
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
kostko
reviewed
Mar 31, 2021
go/worker/storage/committee/node.go
Outdated
| // watcherState is the (persistent) watcher state. | ||
| type watcherState struct { | ||
| LastBlock blockSummary `json:"last_block"` | ||
| } | ||
|
|
||
| // Node watches blocks for storage changes. | ||
| type Node struct { // nolint: maligned | ||
| hostNode control.ControlledNode |
There was a problem hiding this comment.
Should this rather be part of the common committee node? It feels like it belongs there instead.
kostko
reviewed
Mar 31, 2021
kostko
approved these changes
Mar 31, 2021
jberci
force-pushed
the
jberci/fix/storage
branch
from
e89db28
to
9631a2a
Compare
Before this change, rounds were considered successfully finalized even if the operation itself actually failed. This would technically lead a corrupt database state. On the other hand, the worker doesn't have much recourse to handle the situation, so the effect with this fix is to stop syncing (since no further rounds will be able to be finalized).
Errors reported by Apply were ignored and the worker just carried on with a corrupt database.
jberci
force-pushed
the
jberci/fix/storage
branch
from
9631a2a
to
0439098
Compare
ptrus
reviewed
Mar 31, 2021
| // It can happen that for this test, the client will keep selecting the byzantine | ||
| // node instead of the other storage nodes and so would never be able to fully sync. | ||
| // It can take up to two minutes for storage-0 to sync in this scenario with the | ||
| // current shuffling method in the storage client. See also #1815. |
There was a problem hiding this comment.
Maybe comment on the issue #1815 to remove this after it's done.
ptrus
approved these changes
Mar 31, 2021
jberci
force-pushed
the
jberci/fix/storage
branch
from
0439098
to
2b80e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid database corruption in certain cases.