Fix checkpoint abort handling #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberci
requested review from
kostko,
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
jberci
force-pushed
the
jberci/fix/checkpoint-abort
branch
from
206c5c1
to
cf90ffc
Compare
kostko
approved these changes
Apr 1, 2021
- The storage worker's checkpoint syncer left the database in an "in-progress" state after a chunk failed to restore, preventing essentially any further modifications. - The mux consensus app never called restore abort functions on failures.
jberci
force-pushed
the
jberci/fix/checkpoint-abort
branch
from
cf90ffc
to
4a68053
Compare
Codecov Report
@@ Coverage Diff @@
## master #3830 +/- ##
==========================================
+ Coverage 67.21% 67.26% +0.05%
==========================================
Files 404 404
Lines 40952 40997 +45
==========================================
+ Hits 27525 27578 +53
+ Misses 9543 9539 -4
+ Partials 3884 3880 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.