Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes from the most recent dry run #3842

Merged
merged 5 commits into from
Apr 8, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 8, 2021

No description provided.

@kostko kostko force-pushed the kostko/fix/dry-run-minor-fixes branch from 0986ed0 to 1f109cc Compare April 8, 2021 11:22
@kostko kostko requested review from ptrus, jberci and tjanez April 8, 2021 11:34
@kostko kostko marked this pull request as ready for review April 8, 2021 11:35
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #3842 (0247880) into master (d72e8e8) will decrease coverage by 0.17%.
The diff coverage is 31.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3842      +/-   ##
==========================================
- Coverage   67.10%   66.92%   -0.18%     
==========================================
  Files         404      404              
  Lines       41397    41414      +17     
==========================================
- Hits        27779    27716      -63     
- Misses       9689     9747      +58     
- Partials     3929     3951      +22     
Impacted Files Coverage Δ
go/common/version/version.go 73.33% <ø> (ø)
go/oasis-node/cmd/node/unsafe_reset.go 60.78% <ø> (ø)
go/oasis-node/cmd/storage/storage.go 5.31% <0.00%> (-0.06%) ⬇️
go/runtime/client/submitter.go 61.74% <14.81%> (-6.92%) ⬇️
go/storage/client/client.go 75.66% <100.00%> (+1.88%) ⬆️
go/storage/mkvs/db/badger/migrate.go 55.67% <100.00%> (ø)
go/runtime/host/sandbox/sandbox.go 69.53% <0.00%> (-12.11%) ⬇️
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-6.55%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.66% <0.00%> (-4.60%) ⬇️
go/consensus/tendermint/full/light.go 48.00% <0.00%> (-4.00%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72e8e8...0247880. Read the comment docs.

@kostko kostko merged commit b58a0aa into master Apr 8, 2021
@kostko kostko deleted the kostko/fix/dry-run-minor-fixes branch April 8, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants