Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/storage/mkvs: Skip already pruned nodes in migration #3857

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 13, 2021

No description provided.

@kostko kostko force-pushed the kostko/fix/mkvs-migrate-prune-shared branch 2 times, most recently from 2ca7ba6 to d930398 Compare April 13, 2021 12:11
@kostko kostko enabled auto-merge April 13, 2021 12:37
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #3857 (d930398) into master (7b412c2) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head d930398 differs from pull request most recent head c6fbe21. Consider uploading reports for the commit c6fbe21 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3857      +/-   ##
==========================================
+ Coverage   67.06%   67.10%   +0.03%     
==========================================
  Files         404      404              
  Lines       41459    41453       -6     
==========================================
+ Hits        27806    27817      +11     
- Misses       9701     9704       +3     
+ Partials     3952     3932      -20     
Impacted Files Coverage Δ
go/storage/mkvs/db/badger/migrate.go 55.29% <0.00%> (-0.30%) ⬇️
go/consensus/tendermint/full/services.go 75.83% <0.00%> (-8.34%) ⬇️
go/keymanager/client/client.go 73.68% <0.00%> (-7.90%) ⬇️
go/storage/api/root_cache.go 80.00% <0.00%> (-4.45%) ⬇️
go/storage/mkvs/tree.go 86.95% <0.00%> (-4.35%) ⬇️
go/consensus/tendermint/roothash/roothash.go 67.16% <0.00%> (-4.23%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.19% <0.00%> (-3.34%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 71.42% <0.00%> (-3.18%) ⬇️
go/storage/mkvs/insert.go 87.67% <0.00%> (-2.74%) ⬇️
go/consensus/tendermint/abci/state.go 72.29% <0.00%> (-2.03%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b412c2...c6fbe21. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/mkvs-migrate-prune-shared branch from d930398 to c6fbe21 Compare April 13, 2021 15:56
@kostko kostko merged commit d4a97fa into master Apr 13, 2021
@kostko kostko deleted the kostko/fix/mkvs-migrate-prune-shared branch April 13, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants