Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply upgrade proposals directly from governance consensus application #3870

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 20, 2021

This should make it more robust in light of fast sync as otherwise the worker
could miss upgrade events in certain edge cases.

This should make it more robust in light of fast sync as otherwise the worker
could miss upgrade events in certain edge cases.
@kostko kostko force-pushed the kostko/fix/governance-apply-mux branch from 72dbc60 to 043b72a Compare April 20, 2021 08:16
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #3870 (c9913a2) into master (26e6168) will decrease coverage by 0.05%.
The diff coverage is 42.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
- Coverage   67.20%   67.15%   -0.06%     
==========================================
  Files         404      404              
  Lines       41516    41445      -71     
==========================================
- Hits        27902    27832      -70     
  Misses       9658     9658              
+ Partials     3956     3955       -1     
Impacted Files Coverage Δ
go/consensus/tendermint/api/api.go 83.11% <ø> (ø)
go/oasis-node/cmd/node/node.go 54.01% <ø> (-1.31%) ⬇️
go/consensus/tendermint/abci/mux.go 57.29% <28.57%> (+0.53%) ⬆️
...consensus/tendermint/apps/governance/governance.go 63.01% <32.25%> (-3.94%) ⬇️
go/consensus/tendermint/full/full.go 64.46% <100.00%> (-0.69%) ⬇️
go/consensus/tendermint/full/helpers.go 100.00% <100.00%> (ø)
go/consensus/tendermint/apps/governance/query.go 83.33% <0.00%> (-16.67%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 68.25% <0.00%> (-6.35%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 62.50% <0.00%> (-6.25%) ⬇️
go/consensus/tendermint/apps/registry/query.go 76.47% <0.00%> (-5.89%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e6168...c9913a2. Read the comment docs.

@kostko kostko merged commit 6b405f5 into master Apr 20, 2021
@kostko kostko deleted the kostko/fix/governance-apply-mux branch April 20, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants