go/cmd/registry: simplify register runtime command #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/cmd-runtime-simplify
branch
from
48f2705
to
da67edf
Compare
kostko
reviewed
Apr 29, 2021
.changelog/3903.internal.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| go/cmd/registry: simplify register runtime command | |||
There was a problem hiding this comment.
I don't think this is internal, but rather a "feature" (or even breaking, but we'll want to backport this).
There was a problem hiding this comment.
I think this should be classified as breaking.
ptrus
force-pushed
the
ptrus/feature/cmd-runtime-simplify
branch
4 times, most recently
from
d746700
to
6adf3d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3903 +/- ##
==========================================
+ Coverage 67.14% 67.26% +0.12%
==========================================
Files 404 404
Lines 41449 41178 -271
==========================================
- Hits 27829 27698 -131
+ Misses 9665 9562 -103
+ Partials 3955 3918 -37
Continue to review full report at Codecov.
|
tjanez
reviewed
Apr 29, 2021
.changelog/3903.feature.md
Outdated
| descriptor, which should simplify generating runtime registration | ||
| transactions. | ||
| The `registy runtime init_genesis` command is removed as runtime | ||
| descriptors in genesis are not singed since `v21.x` making the command |
There was a problem hiding this comment.
Suggested change
| descriptors in genesis are not singed since `v21.x` making the command | |
| descriptors in genesis are not singed since version 21.0+ making the command |
kostko
approved these changes
Apr 29, 2021
ptrus
force-pushed
the
ptrus/feature/cmd-runtime-simplify
branch
from
6adf3d2
to
d655883
Compare
Update gen_register runtime command to accept runtime descriptor path instead of messing with the arguments.
ptrus
force-pushed
the
ptrus/feature/cmd-runtime-simplify
branch
from
d655883
to
03a7032
Compare
This was referenced May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3626
Update
gen_registerruntime command to accept runtime descriptor instead of messing with the arguments.TODO: