{Add,Reclaim}EscrowEvent: include share amounts #3944
Conversation
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/feature/staking-escrow-events
branch
from
71f385f
to
41834da
Compare
.changelog/3939.bugfix.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| Update emitted events when disbursing rewards | |||
There was a problem hiding this comment.
This may break integrations for custody providers which are parsing events for rewards. Should reclassify as breaking.
There was a problem hiding this comment.
Fixed. But do we want this change right? An alternative is also keeping it as it is and just having it documented
There was a problem hiding this comment.
Yeah I think it makes tracking rewards more clear. We should just give a heads up when we release this.
ptrus
force-pushed
the
ptrus/feature/staking-escrow-events
branch
from
41834da
to
7c50e7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
+ Coverage 67.04% 67.13% +0.08%
==========================================
Files 406 406
Lines 41300 41351 +51
==========================================
+ Hits 27689 27759 +70
+ Misses 9667 9651 -16
+ Partials 3944 3941 -3
Continue to review full report at Codecov.
|
| @@ -617,6 +617,7 @@ type AddEscrowEvent struct { | |||
| Owner Address `json:"owner"` | |||
| Escrow Address `json:"escrow"` | |||
| Amount quantity.Quantity `json:"amount"` | |||
| NewShares quantity.Quantity `json:"new_shares"` | |||
ptrus
force-pushed
the
ptrus/feature/staking-escrow-events
branch
from
7c50e7c
to
2ee7d39
Compare
Fixes: #3939
Also fixed
Escrowevents emitted when disbursing rewards. I think explicitly emitting (transfer and self-escrow) events makes more sense?