runtime/common/crypto/signature: Switch Ed25519 to our consensus flavor #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Yawning
force-pushed
the
yawning/feature/rust-ed25519
branch
from
aabd9b8
to
a795d3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3946 +/- ##
==========================================
+ Coverage 66.99% 67.01% +0.02%
==========================================
Files 406 406
Lines 41300 41351 +51
==========================================
+ Hits 27667 27713 +46
+ Misses 9681 9679 -2
- Partials 3952 3959 +7
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/rust-ed25519
branch
5 times, most recently
from
f88fd11
to
812ec65
Compare
We currently use semantics that are close to ed25519-dalek's strict, but we require using the cofactored verification equation. Implementing verification ourselves lets us alter the behavior in the future as we see fit, though "Just use Ristretto".
Yawning
force-pushed
the
yawning/feature/rust-ed25519
branch
from
812ec65
to
aa0544b
Compare
|
You know what makes writing Rust even less fun than it already is? Having to use CI as the compiler. |
Yawning
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use semantics that are close to ed25519-dalek's strict,
but we require using the cofactored verification equation. Implementing
verification ourselves lets us alter the behavior in the future as
we see fit, though "Just use Ristretto".
TODO:
cargo testfails with modern GCC #3947)