-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: specify ring version #3981
Conversation
9f4d9f5
to
1469aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. What's with all the updates in Cargo.lock
?
I updated Cargo.lock (via I think now that |
Ok. While doing this, we should also update the crate versions to something other than |
Hm yeah i think we should just remove the version for now? |
Agreed, let's remove it. |
Codecov Report
@@ Coverage Diff @@
## master #3981 +/- ##
==========================================
- Coverage 67.28% 67.24% -0.04%
==========================================
Files 410 410
Lines 41828 41828
==========================================
- Hits 28144 28129 -15
- Misses 9727 9743 +16
+ Partials 3957 3956 -1
Continue to review full report at Codecov.
|
1469aa9
to
f688ec8
Compare
Specify exact ring version in
Cargo.toml
as otherwise project depending on oasis-runtime (e.g. oasis-sdk), will need to manually lockring
to the exact version.