Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common: Wait for all child workers to initialize #4001

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 7, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #4001 (4d47d5b) into master (0eef15a) will increase coverage by 0.16%.
The diff coverage is 78.44%.

❗ Current head 4d47d5b differs from pull request most recent head 152a6ad. Consider uploading reports for the commit 152a6ad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4001      +/-   ##
==========================================
+ Coverage   67.08%   67.24%   +0.16%     
==========================================
  Files         411      411              
  Lines       42099    42178      +79     
==========================================
+ Hits        28241    28362     +121     
+ Misses       9868     9837      -31     
+ Partials     3990     3979      -11     
Impacted Files Coverage Δ
go/runtime/host/protocol/connection.go 66.14% <ø> (+3.14%) ⬆️
go/runtime/host/protocol/types.go 47.36% <ø> (ø)
go/runtime/scheduling/init.go 60.00% <ø> (ø)
go/runtime/scheduling/simple/simple.go 80.00% <ø> (ø)
go/worker/common/committee/node.go 71.35% <62.50%> (-0.36%) ⬇️
go/runtime/transaction/transaction.go 78.78% <71.42%> (-0.49%) ⬇️
go/runtime/host/helpers.go 67.34% <75.00%> (+6.37%) ⬆️
go/worker/compute/executor/committee/node.go 71.96% <76.92%> (+2.11%) ⬆️
go/runtime/host/mock/mock.go 89.74% <100.00%> (+0.85%) ⬆️
...ling/simple/txpool/priorityqueue/priority_queue.go 86.95% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82aa4b...152a6ad. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/worker-cmn-wait-subinit branch from 4d47d5b to 152a6ad Compare June 7, 2021 09:02
@kostko kostko marked this pull request as ready for review June 7, 2021 09:05
@kostko kostko enabled auto-merge June 7, 2021 09:05
@kostko kostko added this to Planned in Core 21.2 via automation Jun 7, 2021
@kostko kostko moved this from Planned to In Progress in Core 21.2 Jun 7, 2021
@kostko kostko merged commit 2e939b2 into master Jun 7, 2021
Core 21.2 automation moved this from In Progress to Done Jun 7, 2021
@kostko kostko deleted the kostko/fix/worker-cmn-wait-subinit branch June 7, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants