go/storage/mkvs/checkpoint: Checkpoint in descending order #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/storage-checkpointer
branch
2 times, most recently
from
8aad760
to
890b72d
Compare
Yawning
approved these changes
Jun 9, 2021
kostko
force-pushed
the
kostko/fix/storage-checkpointer
branch
from
890b72d
to
284c0b4
Compare
Previously the checkpointer would generate checkpoints in ascending order which meant that it could generate many checkpoints only to garbage collect them in the next step.
kostko
force-pushed
the
kostko/fix/storage-checkpointer
branch
from
284c0b4
to
642b49a
Compare
kostko
force-pushed
the
kostko/fix/storage-checkpointer
branch
from
642b49a
to
bb33acb
Compare
kostko
force-pushed
the
kostko/fix/storage-checkpointer
branch
from
bb33acb
to
d45fdf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the checkpointer would generate checkpoints in ascending order which
meant that it could generate many checkpoints only to garbage collect them in
the next step.