Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates useful for oasis-sdk#96 #4025

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Updates useful for oasis-sdk#96 #4025

merged 2 commits into from
Jun 18, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 14, 2021

Some updates useful for oasisprotocol/oasis-sdk#96

  • configurable libp2p gossipsub validator concurrences
  • increase runtime/src/dispatcher.rs channel backlog size
  • support setting custom node arguments in oasis-runner fixtures

go/worker/common/p2p/init.go Outdated Show resolved Hide resolved
@@ -53,7 +53,8 @@ use crate::{
};

/// Maximum amount of requests that can be in the dispatcher queue.
const BACKLOG_SIZE: usize = 1000;
// XXX: make this configurable?
const BACKLOG_SIZE: usize = 10000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to #2548?

Copy link
Member Author

@ptrus ptrus Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, yeah should probably do #2548 now that CheckTx is required on executors

go/oasis-test-runner/oasis/fixture.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #4025 (188b67c) into master (06c4722) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 188b67c differs from pull request most recent head 51e4e23. Consider uploading reports for the commit 51e4e23 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
- Coverage   67.08%   67.04%   -0.05%     
==========================================
  Files         410      410              
  Lines       42157    42190      +33     
==========================================
+ Hits        28282    28287       +5     
- Misses       9890     9915      +25     
- Partials     3985     3988       +3     
Impacted Files Coverage Δ
go/worker/common/p2p/init.go 100.00% <100.00%> (ø)
go/worker/common/p2p/p2p.go 71.42% <100.00%> (+1.25%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/common/grpc/proxy/proxy.go 65.74% <0.00%> (-5.56%) ⬇️
go/common/sgx/common.go 58.53% <0.00%> (-4.88%) ⬇️
go/storage/api/root_cache.go 80.00% <0.00%> (-4.45%) ⬇️
go/common/badger/migrate.go 0.00% <0.00%> (-4.00%) ⬇️
...nt/apps/supplementarysanity/supplementarysanity.go 80.39% <0.00%> (-3.93%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c4722...51e4e23. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/benchs branch 2 times, most recently from b7e292f to 188b67c Compare June 14, 2021 09:52
@ptrus ptrus mentioned this pull request Jun 15, 2021
5 tasks
@ptrus ptrus force-pushed the ptrus/feature/benchs branch 2 times, most recently from f967457 to d664df2 Compare June 18, 2021 06:49
@ptrus ptrus marked this pull request as ready for review June 18, 2021 06:49
@ptrus ptrus added the s:ready-ci Status: ready for CI label Jun 18, 2021
@ptrus ptrus mentioned this pull request Jun 18, 2021
@ptrus ptrus enabled auto-merge June 18, 2021 07:06
@ptrus ptrus merged commit 2b53076 into master Jun 18, 2021
@ptrus ptrus deleted the ptrus/feature/benchs branch June 18, 2021 07:24
ptrus added a commit that referenced this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:ready-ci Status: ready for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants