go/consensus/tendermint/apps/staking: Fix emitted reward events #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/staking-evt-reward-xfer
branch
from
0d4396f
to
15588da
Compare
Using typed events makes it slightly harder to use an incorrect key/value combination. Unfortunately we cannot use this in all of the cases due to events in registry/roothash not being nicely structured and changing this would require existing nodes to resync due to internal event key changes.
kostko
force-pushed
the
kostko/fix/staking-evt-reward-xfer
branch
from
15588da
to
32eeab6
Compare
kostko
commented
Jun 16, 2021
Comment on lines
+4
to
+6
| combination. Unfortunately we cannot use this in all of the cases due to | ||
| events in registry/roothash not being nicely structured and changing this | ||
| would require existing nodes to resync due to internal event key changes. |
There was a problem hiding this comment.
Opened #4034 to track this.
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
tjanez
approved these changes
Jun 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #4033 +/- ##
==========================================
+ Coverage 67.04% 67.05% +0.01%
==========================================
Files 410 410
Lines 42183 42148 -35
==========================================
- Hits 28280 28263 -17
+ Misses 9909 9897 -12
+ Partials 3994 3988 -6
Continue to review full report at Codecov.
|
ptrus
approved these changes
Jun 16, 2021
Yawning
approved these changes
Jun 16, 2021
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.