Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badger/migration: keep only last version when migrating non-managed DB #4037

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 16, 2021

Even though oasis-core always configures non-managed badger databases to keep
a single version of keys, some databases in the wild contain multiple versions
of the same key.

Skip migrating more than the latest version when migrating non-managed
badger databases.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #4037 (ea119be) into master (d73b8b2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head ea119be differs from pull request most recent head dfcd789. Consider uploading reports for the commit dfcd789 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4037      +/-   ##
==========================================
- Coverage   67.07%   67.06%   -0.01%     
==========================================
  Files         410      410              
  Lines       42148    42151       +3     
==========================================
- Hits        28271    28270       -1     
+ Misses       9894     9892       -2     
- Partials     3983     3989       +6     
Impacted Files Coverage Δ
go/common/badger/helpers.go 35.29% <0.00%> (-0.35%) ⬇️
go/common/badger/migrate.go 0.00% <0.00%> (ø)
go/common/sgx/aesm/aesm.go 62.61% <0.00%> (-8.42%) ⬇️
go/storage/api/root_cache.go 80.00% <0.00%> (-4.45%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.19% <0.00%> (-3.34%) ⬇️
go/worker/storage/service_external.go 54.28% <0.00%> (-2.86%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.66% <0.00%> (-2.30%) ⬇️
go/runtime/host/sgx/sgx.go 71.42% <0.00%> (-2.20%) ⬇️
go/storage/mkvs/cache.go 83.91% <0.00%> (-2.02%) ⬇️
go/storage/client/client.go 74.77% <0.00%> (-1.77%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73b8b2...dfcd789. Read the comment docs.

Even though oasis-core always configures non-managed badger databases to keep
a single version of keys, some databases in the wild contain multiple versions
of the same key.

Skip migrating more than the latest version when migrating non-managed
badger databases.
@ptrus ptrus force-pushed the ptrus/fix/migration branch 2 times, most recently from 2b0d1ae to f8df31d Compare June 16, 2021 16:12
@ptrus ptrus added the s:ready-ci Status: ready for CI label Jun 16, 2021
@ptrus ptrus enabled auto-merge June 16, 2021 16:33
@ptrus ptrus merged commit 9fba625 into master Jun 16, 2021
@ptrus ptrus deleted the ptrus/fix/migration branch June 16, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:ready-ci Status: ready for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants