go/common/errors: expose all grpc errors as coded #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
requested review from
peterjgilbert,
pro-wh,
ptrus and
Yawning
as code owners
nhynes
force-pushed
the
nhynes/code-all-grpc-errors
branch
from
fda541c
to
0b22aa9
Compare
kostko
approved these changes
Jun 23, 2021
nhynes
force-pushed
the
nhynes/code-all-grpc-errors
branch
from
0b22aa9
to
a809930
Compare
ptrus
approved these changes
Jun 25, 2021
nhynes
force-pushed
the
nhynes/code-all-grpc-errors
branch
from
a809930
to
5a0762b
Compare
|
FYI, I don't have permissions to make CI run. |
Just add the label as @ptrus did above and re-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to decode the actual error variant via
detailsin the gRPC error response status.re: oasisprotocol/oasis-sdk@860e423